Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay limbs for improved client performance #4290

Merged
merged 12 commits into from
Sep 4, 2023

Conversation

harryob
Copy link
Member

@harryob harryob commented Aug 30, 2023

from:
image

to:
image

lower number is obviously good, especially on clients because this can make being on the front with a bunch of humans incredibly laggy

for some reason we use vis_contents for limbs, which simplifies their icon updating. however it does also make clients lag the fuck out for whatever reason so we shouldn't do that

also the fact that we copy these to ghosts doesn't help and can really start multiplying things

can also remove iterating through visobjs in gFI, so ended up porting over the readability changes from mothblocks on tg here:
tgstation/tgstation#60285

god willing no player facing changes

@harryob harryob marked this pull request as draft August 30, 2023 20:27
@harryob harryob marked this pull request as ready for review August 31, 2023 08:06
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for tm

@BeagleGaming1 BeagleGaming1 added this pull request to the merge queue Sep 4, 2023
Merged via the queue into cmss13-devs:master with commit 3d8b380 Sep 4, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants